From 1c725ea024bc7075df8a79b5d8a66eadfb7daf6e Mon Sep 17 00:00:00 2001 From: Frank Date: Mon, 5 Oct 2026 18:18:21 -0700 Subject: [PATCH] e2e: run.sh keeps playwright arg passthrough with the default project set The default-project-set rewrite dropped non---project args (e.g. --list), so 'run.sh --list' silently RAN the whole suite instead of listing. Args now ride alongside the default set; an explicit --project still takes over. Verified: default --list = 33 tests listed; opt-in --list = 34 with the frankbook walk. --- tests/e2e/run.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/e2e/run.sh b/tests/e2e/run.sh index 90ada04..b25341c 100755 --- a/tests/e2e/run.sh +++ b/tests/e2e/run.sh @@ -31,8 +31,9 @@ fi npx playwright install chromium # Default project set; the frankbook project joins only when deploy.sh saw a -# frankbook trigger path (E2E_INCLUDE_FRANKBOOK=1). An explicit --project in -# "$@" takes over untouched. +# frankbook trigger path (E2E_INCLUDE_FRANKBOOK=1). Other playwright args +# (--list, --grep, file filters) pass through alongside the default set; an +# explicit --project in "$@" takes over untouched. DEFAULT_PROJECTS=(setup standard admin guest) if [[ "${E2E_INCLUDE_FRANKBOOK:-0}" == "1" ]]; then DEFAULT_PROJECTS+=(frankbook) @@ -43,11 +44,10 @@ for arg in "$@"; do --project|--project=*) has_project=1 ;; esac done -if [[ "$has_project" -eq 1 ]]; then - exec npx playwright test "$@" -fi PROJECT_ARGS=() -for project in "${DEFAULT_PROJECTS[@]}"; do - PROJECT_ARGS+=(--project "$project") -done -exec npx playwright test "${PROJECT_ARGS[@]}" +if [[ "$has_project" -eq 0 ]]; then + for project in "${DEFAULT_PROJECTS[@]}"; do + PROJECT_ARGS+=(--project "$project") + done +fi +exec npx playwright test "$@" "${PROJECT_ARGS[@]}"