0 Fork 0

Files

T

Frank 8af40c402b chore(agent): commit the machine tier and the doctrine text the checkout was already running

Landing blocker for #61 and #63: the deployment checkout is 12 commits behind and
`merge --ff-only` refuses while tracked paths are dirty. Discard is not available here
(workspace policy: no `checkout`/`stash` on shared state), so the dirt is committed.

- `agent/APPEND_SYSTEM.md`: the point-of-use / one-work-log / PR-link doctrine, already
  byte-identical to `origin/main` (`cmp` against the trunk blob: no difference). No new
  prose — the commit exists so the trunk merge can proceed.
- `agent/config.yml` and `agent/managed-skills/**`: the machine-live tier the heartbeat
  owns (AGENTS.md § Live-sync tiers).

`ALLOW_SECRETS=1` was used, deliberately and after auditing the staged diff by hand: the
only credential-shaped strings in it are two copies of `AKIA0000000000000EXAMPLE` — the
inert all-zero AWS example id — and they appear inside the two skill pages that teach
that exact placeholder shape. This checkout is still running the pre-#61 hook; the merged
gate (value-scoped placeholder filter, `71601f7`) exempts this value, so the refusal
dies with this landing. No `--no-verify` was used: the gate ran and its verdict is
recorded here.

Refs #61

2026-10-21 01:44:51 -07:00

3.2 KiB

Raw Blame History

name, description

name	description
shell-suite-green-locale-proof	Proving a bats/shell suite is actually green (grep, never tail) and debugging generated output that silently loses content under LC_ALL=C (multibyte quantifiers in awk/grep). Use when reporting "suite green", or when a generator emits partial output with exit 0.

Proving a suite is green, and locale-blind generators

Two failure modes earned on dank/command-center (2026-10-20): a false "all tests pass" report, and a generator that silently dropped a third of its output.

1. Never report green from a `tail` window

bats tests/ | tail -25 shows the last tests, not the failures — not ok lines print inline at their position and vanish off the top. A "109 ok, 0 failures" claim built this way was wrong; the claim had to be corrected in the merged PR's body.

out=$(bats tests/ 2>&1)
printf '%s\n' "$out" | grep -cE '^ok'        # passing count
printf '%s\n' "$out" | grep -E '^not ok'     # THIS is the claim; empty == green

Also: a suite can be green under the operator's terminal and red under a C locale, so run both before writing "green" in a PR body:

env -u LC_ALL bats tests/    # operator's locale (LANG from the desktop session)
LC_ALL=C bats tests/         # cron, systemd user units, agent shells

State which locale each number came from. Agent shells in this fleet run LC_ALL=C even when LANG=en_US.UTF-8 — LC_ALL overrides everything.

2. Multibyte quantifiers silently truncate generated output

A quantifier on a multibyte character (─+, ━+, →*) breaks under LC_ALL=C: gawk matches byte-wise, so ─+ means "the last byte of U+2500, repeated", which never occurs in real text. Symptom: output loses every match — sections, headers, rows — with exit status 0. No error, no partial-write warning.

# broken under C
awk '/^[[:space:]]*\/\/[[:space:]]*─+ (.+) ─+[[:space:]]*$/'
# byte-safe in every locale: match the multibyte char as a LITERAL, no quantifier
/^[[:space:]]*\/\/[[:space:]]*─/ {
  s = $0; sub(/^[[:space:]]*\/\/[[:space:]]*/, "", s)
  if (s ~ /─ .*─/) { gsub(/─/, "", s); gsub(/[[:space:]]+/, " ", s) }
}

Do NOT "fix" it by pinning a locale (LC_ALL=en_US.UTF-8) — that locale may not be installed; a CachyOS box here shipped only C.utf8. Make the matcher locale-independent.

3. Prove the loss, don't infer it

Diff old vs new against real input in both locales, with counts, before claiming a fix:

git show origin/main:scripts/gen-keybinds.sh > /tmp/old.sh
for L in C C.utf8; do
  printf '%s: old=' "$L"; LC_ALL=$L bash /tmp/old.sh "$REAL" | grep -c '^## '
  printf        ' new=';       LC_ALL=$L scripts/gen-keybinds.sh "$REAL" | grep -c '^## '
done   # old printed 0 sections vs 12 under C, 120 rows intact, exit 0

Check whether a committed generated artifact was produced by a bad run — if it has the full content, it came from a UTF-8 shell and needs no regeneration.

4. Gates must not demand deletion

Repo linters walking .AGENTTRASH/ (quarantined, gitignored) turn green only once the quarantined page is deleted — an incentive to destroy history. Skip any path containing .AGENTTRASH in both the linter and the coverage checker, and pin it with a test.

3.2 KiB Raw Blame History